tosh Report post Posted May 26, 2011 (edited) Hello, I developed a ranging window for see statistics about this skill. For the moment, we can open the window only with CTRL+r (Or you must change the key.ini file with the #K_RANGINGWIN key). I used a new feature for the code, so you must compile with RANGING_WIN enable. Actually, the code about the ranging window is in missiles.c. I think, create new files is a better thing. A screenshot : The patch : http://tosh-codes.tuxfamily.org/UPLOADS/ranging_win.txt So, can I use this patch IG ? Is it a good idea ? If anybody have any suggestion, don't hesitates . PS : sorry for my bad english. Edited May 27, 2011 by tosh Share this post Link to post Share on other sites
Wizzy Report post Posted May 26, 2011 I love it personaly! Share this post Link to post Share on other sites
Raz Report post Posted May 26, 2011 (edited) OMG love it....... I guess the first line is Arrows shot - not total hits. Can you alo add in any of : Arrows saved Avg damage Edited May 26, 2011 by Raz Share this post Link to post Share on other sites
Usl Report post Posted May 26, 2011 Here is a good window for placing the "Shoot at will" button, to be used in GP Arena Share this post Link to post Share on other sites
tosh Report post Posted May 27, 2011 I guess the first line is Arrows shot - not total hits. Yes, I will change it. Can you alo add in any of : Arrows saved Avg damage I think, it's more difficult. The client don't have these informations. For the arrows saved I have a little idea, but for the damages I don't know if it's possible actually. Share this post Link to post Share on other sites
Entris Report post Posted May 27, 2011 This is looking great! Would a Total Miss be possible to add? Share this post Link to post Share on other sites
tosh Report post Posted May 27, 2011 Sure, it's possible . I edited my original post. (patch + screenshot) Share this post Link to post Share on other sites
Sir_Odie Report post Posted May 27, 2011 nice one :=)) Share this post Link to post Share on other sites
Entris Report post Posted May 28, 2011 Very nice, well done Share this post Link to post Share on other sites
Roja Report post Posted May 28, 2011 That looks nice! Any reason not to include it in the statistics window? Share this post Link to post Share on other sites
Wizzy Report post Posted May 28, 2011 That looks nice! Any reason not to include it in the statistics window? My first thoughts would be nice if it was in stats window Share this post Link to post Share on other sites
bluap Report post Posted May 28, 2011 Being separate from the stats window, it can be much smaller (could be smaller even still) and left visible. If it's left as a separate window, you could include the window id in the list for change_windows_on_top() in elconfig.c so it behaves like other windows. Saving the last position might also be nice. Share this post Link to post Share on other sites
tosh Report post Posted May 28, 2011 Yes the window is smaller than the stats window so you can show the windows during you are ranging. To put it in stats window, I must create a new tab, no ? I can do it if you think the stats window is a better place for that. If it's left as a separate window, you could include the window id in the list for change_windows_on_top() in elconfig.c so it behaves like other windows. Saving the last position might also be nice. Ok, if I don't put it in stats window, I will change that . Share this post Link to post Share on other sites
bluap Report post Posted May 31, 2011 I asked Radu/Entropy and he is happy for me to commit this patch. So is there a conclusion to the stats-tab / separate window debate? Either way, there's a little more work to be done before I commit. Share this post Link to post Share on other sites
Raz Report post Posted June 1, 2011 That's great news! I would say separate - as this could be used whilst ranging - where screen space is at a premium. Can we also have a reset button to clear down the counters! Share this post Link to post Share on other sites
groomsh Report post Posted June 1, 2011 Yeah i'd also say that a separate window (resizable would be great) would be better. @Raz: reset button is a very good idea Share this post Link to post Share on other sites
tosh Report post Posted June 1, 2011 You can reset the ranging stats with the reset session button. I don't know if it's a good idea, but the XP/arrows is calculate with the session experience. Share this post Link to post Share on other sites
bluap Report post Posted June 1, 2011 (edited) Regarding a stats tab or separate window, I hear on good authority (Radu) that Roja is happy with what ever people want. On the limited set of opinions in this thread, I'd say having a separate (small) window is preferred. Apologies if I appear pushy on this but we have a new client release coming very soon and this patch could be included if ready. Edited June 1, 2011 by bluap Share this post Link to post Share on other sites
Maxine Report post Posted June 2, 2011 I like a separate small window, most of the time I am ranging, I am not doing anything else interesting Share this post Link to post Share on other sites
bluap Report post Posted June 25, 2011 Patch committed to git, thanks tosh. Share this post Link to post Share on other sites
bluap Report post Posted June 27, 2011 It was pointed out to me today that the key used to open this new window is already allocated. Ctrl+r is used to repeat the last spell. So which key shall we move the ranging window to? A quick check shows that only ctrl+t and ctrl+y are free! Share this post Link to post Share on other sites
Raistlin Report post Posted June 28, 2011 It was pointed out to me today that the key used to open this new window is already allocated. Ctrl+r is used to repeat the last spell. So which key shall we move the ranging window to? A quick check shows that only ctrl+t and ctrl+y are free! CTRL+Y opens up session counter (xp) Share this post Link to post Share on other sites
bluap Report post Posted June 28, 2011 CTRL+Y opens up session counter (xp) Not according to the source code or the shipped key.ini file. The source code shows ctrl+z for the session counter. Could it be that you have added that key definition yourself? Share this post Link to post Share on other sites
Raistlin Report post Posted June 28, 2011 (edited) CTRL+Y opens up session counter (xp) Not according to the source code or the shipped key.ini file. The source code shows ctrl+z for the session counter. Could it be that you have added that key definition yourself? ah ok, then it's europe vs. US keyboard layout I guess. nvm then Edited June 28, 2011 by Raistlin Share this post Link to post Share on other sites
