#rule command not working properly

[Roja]

The #rule command for moderators is no longer making the rule window(f5) to popup and highlight the rule broken. All it currently does it give a message "you have been warned by _moderator_!"

 

Can someone fix this?

[bluap]

The #rule command for moderators is no longer making the rule window(f5) to popup and highlight the rule broken. All it currently does it give a message "you have been warned by _moderator_!"

Can someone fix this?

Does it work if you specify more than two rules to highlight? If only one or two rules are specified, does the recipient get a message in error_log.txt such as "CAUTION: Possibly forged DISPLAY_CLIENT_WINDOW packet received."?

 

In version 1.216 of multiplayer.c a message size check was added, that could be the problem:

 

		case DISPLAY_CLIENT_WINDOW:
		{
			if (data_length <= 6)
			{
			  log_error("CAUTION: Possibly forged DISPLAY_CLIENT_WINDOW packet received.\n");
			  break;
			}

[Roja]

Yes it does work if at least 3 rules are specified. If only 1 or 2, it does not work.

And yes there is that error message:

CAUTION: Possibly forged DISPLAY_CLIENT_WINDOW packet received.

[bluap]

Yes it does work if at least 3 rules are specified. If only 1 or 2, it does not work.

And yes there is that error message:

CAUTION: Possibly forged DISPLAY_CLIENT_WINDOW packet received.

OK, then I suggest someone change the check to (data_length <= 4).

 

As a work around until its fixed, try specifing the same rule 3 times.

Edited July 22, 2007 by bluap

[Torg]

And the fix is in. Thanks bluap.

[asgnny]

And the fix is in. Thanks bluap.

 

Patch in CVS is confirmed as working.