Astrology GUI

[Fedora]

Checking astro i got this:

 

 

 

bug or extremely bad luck

 

 

 

Ibook G4, Tiger 10.4.11

Edited December 2, 2007 by Fedora

[bluap]

Was this the bug fixed with schmurk's recent CVS commit?

"- corrected a bug that was displaying all the lines of the interface

with a size of 2 pixels instead of 1 when the astrology indicator window

was opened"

If so we can close the Mantis report .

[Schmurk]

No, nothing to do with that. The bug I've corrected is that when you have this window opened, all the other lines on the client interface take a width of 2 pixels instead of 1 because there was missing a glPointSize(1.0) at the end of the function that displays the content of this window.

[bluap]

No, nothing to do with that. The bug I've corrected is that when you have this window opened, all the other lines on the client interface take a width of 2 pixels instead of 1 because there was missing a glPointSize(1.0) at the end of the function that displays the content of this window.

Shame, I wouldn't know because I don't use the feature.

[Wingalings]

I have the same bug.

 

This one using the el_patch.exe:

 

And this one using the el_pre_rc_24_02_07.exe:

 

It only seems to happen with the Acc/magic indicator.

[Alberich]

Here a small hint:

...

4. Accuracy.**

...

** the accuracy bonus is based on your attack level; the higher the level, the more bonus you get, capped at 5 or so.

and the code astrology.c line 326 & 365:

float calculate_width_coefficient(int amplitude,int value,int invert)
{
float Result = ((float)value / (float)amplitude);
...
}
...
			case atAccMagicIndicator:
			{
				coefficient1 = calculate_width_coefficient(your_info.attack_skill.base/20,value1,0);
				coefficient2 = calculate_width_coefficient(9,value2,0);
			}break;
...
			case atAccPredictor:
			case atAttPredictor: 
			{
				coefficient1 = calculate_width_coefficient(your_info.attack_skill.base/20,value1,0);
				coefficient2 = calculate_width_coefficient(your_info.attack_skill.base/20,value2,0);
				coefficient3 = calculate_width_coefficient(your_info.attack_skill.base/20,value3,0);
			}break;

so people with att < 100 (or 90?) can get this bug (if the cap is 5).

 

is the server calculating too high values for low att level players?

i.e.: should it be possible for an att level 20 player to get +/-5 acc?

[Schmurk]

Only the server knows the right formula to compute the accuracy according to the attack level. The only thing we know is that it should be capped to 5 so let's use this value. And if a player with a low attack never reach this number, does it really matter? The only thing to be sure is that it never goes over 5 though...

Can you confirm this Ent?

[Cycloonx]

Isn't it % based? (like 5% of your A/D as max value)

[bluap]

I've just changed the code to limit the bar length if it would go outside the window. I also report the problem to the error log file. Not a fix but at least it doesn't look stupid now.