Server tracking

[Drakos7]

Can you make sure that the logging of info like OpenGL versions is a config option? A few people might not like their system being queried for such information even if it does help our development.

[Florian]

Well, doesn't compile anyway ...

 

sendvideoinfo.cpp: In function 'void send_video_info()':
sendvideoinfo.cpp:172: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:172: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'
sendvideoinfo.cpp:175: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:175: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'
sendvideoinfo.cpp:178: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:178: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'
sendvideoinfo.cpp:182: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:182: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'

 

patch

 

Index: sendvideoinfo.cpp
===================================================================
RCS file: /cvsroot/elc/elc/sendvideoinfo.cpp,v
retrieving revision 1.1
diff -u -d -p -r1.1 sendvideoinfo.cpp
--- sendvideoinfo.cpp   7 Sep 2007 01:08:14 -0000	   1.1
+++ sendvideoinfo.cpp   7 Sep 2007 07:44:43 -0000
@@ -140,7 +140,7 @@ extern "C" void send_video_info()
	bit_set_96 caps;
	xmlNode *root_element;
	xmlDoc *document;
-	   int i;
+	   GLint i;

	if (video_info_sent == 0)
	{

 

Don't whether this patch breaks functionality, it does compile though.

Edited September 7, 2007 by Florian

[Xaphier]

Well, doesn't compile anyway ...

 

sendvideoinfo.cpp: In function 'void send_video_info()':
sendvideoinfo.cpp:172: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:172: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'
sendvideoinfo.cpp:175: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:175: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'
sendvideoinfo.cpp:178: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:178: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'
sendvideoinfo.cpp:182: error: invalid conversion from 'int*' to 'GLint*'
sendvideoinfo.cpp:182: error:   initializing argument 2 of 'void glGetIntegerv(GLenum, GLint*)'

 

patch

 

Index: sendvideoinfo.cpp
===================================================================
RCS file: /cvsroot/elc/elc/sendvideoinfo.cpp,v
retrieving revision 1.1
diff -u -d -p -r1.1 sendvideoinfo.cpp
--- sendvideoinfo.cpp   7 Sep 2007 01:08:14 -0000	   1.1
+++ sendvideoinfo.cpp   7 Sep 2007 07:44:43 -0000
@@ -140,7 +140,7 @@ extern "C" void send_video_info()
	bit_set_96 caps;
	xmlNode *root_element;
	xmlDoc *document;
-	   int i;
+	   GLint i;

	if (video_info_sent == 0)
	{

 

Don't whether this patch breaks functionality, it does compile though.

Thanks for this, it was only a typo. Is in CVS now.

 

Can you make sure that the logging of info like OpenGL versions is a config option? A few people might not like their system being queried for such information even if it does help our development.

Is done. Set video_info_sent to one in el.ini and no data is send. The default value is zero for video_info_sent and after sending the data, the var is set to one, so that the data is only send once.

[Drakos7]

Thx Xaphier. Nice idea to send it just once.

[Entropy]

I personally don't think there is any privacy concerns with what we send, afterall we only send the video card information, nothing that can be connected to specific computers or hardware.

Sort of like the user agent thing the browser sends to websites.