Client popup menu

[alvieboy]

Ok, thanks.

The test server should help find the problems and test the code.

 

Hi,

 

Been doing some debug, and found something you should not be doing - adding different type of entries to the same group id:

 

Adding text option, group 21

Adding radio, group 21

Adding radio, group 21

Adding display text, group 50

Adding text entry, group 60

 

The behaviour is unexpected if you do it. However, on this simple test scenario, it almost looks like it works, because:

- You have other than text options in the menu, so the text options are changed to radiobuttons;

- The group 21 has therefore 3 radio entries.

 

However, there seems to be another problem. I re-added the value 0 for text entries, and this is what I get as reply from the server:

 

[09:59:01] popup id: 5

[09:59:02] Group ID: 21, Value ID: 24

[09:59:02] Group ID: 104, Text: h

 

My packet looks like this:

32 05 00 15 18 3c 00 05 68 65 6c 6c 6f 

32 05 00   15	18	 3c	00	05	  68656c6c6f
-- ------- ----- ------ ----- ----- ------- ----------
PR PopupID Gr 21 Val 24 Gr 60 Val 0 TextLen  h e l l o

PR=popup reply

104 = 68h = 'h'

 

I will upload a patch to add that 0 value for text entries.

 

Álvaro

 

Is there any way you can make the text entry window change the color when the mouse is over it? Without massive modifications, that is.

 

Think so, but not really sure. Let me make some experiments.

 

Álvaro

[Entropy]

Ok, that might be my bug, I couldn't properly test it because the client was not sending the 0.

Now that it does, I'll take another look at it.

Can you make a patch with the fix?

[alvieboy]

Ok, that might be my bug, I couldn't properly test it because the client was not sending the 0.

Now that it does, I'll take another look at it.

Can you make a patch with the fix?

 

It's in berlios already, awaiting approval.

 

Patch here

 

Álvaro

[bluap]

It's in berlios already, awaiting approval.

Patch here

Committed to CVS.

[Entropy]

Well, with out limited tests, it seems that everything works as it is supposed to.

However, if you have some time, you could add additional debug test menus to your client and see if there is any problem with the server response (test server).

 

Great work, btw!

[alvieboy]

Well, with out limited tests, it seems that everything works as it is supposed to.

However, if you have some time, you could add additional debug test menus to your client and see if there is any problem with the server response (test server).

Sure. I'll do that today.

Great work, btw!

Thanks.