Translation via XML of the windowstittle

[Lhibou]

Patch 639

 

Almost all the buttons and windows titles can be translated via the file title.xml.

[Lachesis]

@@ -360,18 +370,17 @@
void display_storage_menu()
{

...

-  vscrollbar_add_extended(storage_win, 1200, NULL, 130, 10, 20, 192, 0, 1.0, 0.77f, 0.57f, 0.39f, 0, 1, 10);
+  vscrollbar_add_extended(storage_win, 1200, NULL, 130, 10, 20, 192, 0, 1.0, 0.77f, 0.57f, 0.39f, 0, 1, 30);
 	vscrollbar_add_extended(storage_win, 1201, NULL, 352, 10, 20, 192, 0, 1.0, 0.77f, 0.57f, 0.39f, 0, 1, 28);
 } else {
 	int i;

...

@@ -151,6 +153,14 @@
 	storage_items[i].quantity=0;
 }
 
+	if ( (cat-12) > 0)
+	{
+  vscrollbar_set_pos(storage_win, 1200, cat-12);
+	}
+	else
+	{
+  vscrollbar_set_pos(storage_win, 1200, 0);
+	}
 vscrollbar_set_pos(storage_win, 1201, 0);
}

These hunks don't belong to this patch, please remove them.

 

-	strncpy(var->shortname, shortname, 5);
+	strncpy(var->shortname, shortname, 7);

Please don't introduce new buffer overflows -- You have to change the size of the shortname field as well. Btw, we need a volunteer to replace these integer constants in favour of sizeof().

Anyone interested?

 

With regards

Lachesis

Edited October 11, 2005 by Lachesis

[Lhibou]

Storage is part of the patch 596 http://www.eternal-lands.com/forum/index.php?showtopic=17615

 

The length of the scrollbar was modified because we have more categories in the french version.

The second part is for showing the red selected categories.

 

I forgot to add the part related to the size of shortname (stats.h).

 

Patch resubmitted with some other translations (new_character windows, some buttons, stats.h, etc..), and I maintained the 2 above modifications.

[Placid]

Btw, we need a volunteer to replace these integer constants in favour of sizeof().

Anyone interested?

 

With regards

Lachesis

208403[/snapback]

What happened to a bit of grep/sed or awk action?

[crusadingknight]

What happened to a bit of grep/sed or awk action?

208588[/snapback]

Maybe that they're constants turning to sizeof calls?

[Zep]

Btw, we need a volunteer to replace these integer constants in favour of sizeof().

Anyone interested?

208403[/snapback]

 

Ill have a go at it.

Edited October 14, 2005 by Zep

[Placid]

Maybe that they're constants turning to sizeof calls?

208752[/snapback]

I didn't really think about it :-D

[Zep]

done guess ill take it for a test drive =), https://developer.berlios.de/patch/download.php?id=653

 

opps, text.c uses it as constraints lol, updated

Edited October 14, 2005 by Zep

[Lachesis]

Storage is part of the patch 596 http://www.eternal-lands.com/forum/index.php?showtopic=17615

The second part is for showing the red selected categories.

208469[/snapback]

This is only necessary if they are not visible at the moment, otherwise it's rather annoying. Can you change it so that it works that way? Thank you

 

With Regards

Lachesis

[Lhibou]

Patch 639 now contains only the stuff needed for the translation, no more interference with patch 596.

 

Going to improve patch 596 later

[Lhibou]

Patch 639 now contains only the stuff needed for the translation, no more interference with patch 596.

 

Going to improve patch 596 later

 

Edit: sorry for the double post, thought that was not added. Error during the submit.

Edited October 15, 2005 by Lhibou

[Lachesis]

Hi Lhibou,

 

I applied patch #639. Sorry for being picky, but if I had committed the new behavior (patch #596) without the team's blessing I would have gotten the bashings. Please make a new thread for patch #596 so everyone can comment. Thank you for it all!

 

With Regards

Lachesis

[Lhibou]

additionnal translations via XML with patch 662

[Lachesis]

Patch applied.

[Lhibou]

Patch id: 682

 

A lot of messages translated, but the most important is the translation of the local commands and the possibility to redefine #, @ and / for the commands (usefull for players having azerty keyboard)

[Lhibou]

patch id 757

 

some variables was not used in the creation interface.

 

Note: I see patch 751 removing the <ctrl-q>, I think it's not needed as the @ can be redefined via XML (implemented in a previous patch).

[Lachesis]

Patch is incomplete, the code for loading the strings [translate.c] is missing.

 

With regards

Lachesis

 

P.S. I accepted patch #751 (masked by #ifdef WINDOWS), because that's the only way to avoid support requests by new users.

Edited December 16, 2005 by Lachesis

[Lhibou]

Patch is incomplete, the code for loading the strings [translate.c] is missing.

 

With regards

Lachesis

 

Code for loading the string is allready in translate.c. Thus patch is complete.

 

Declarations were missing and translate.h.

[Lachesis]

Patch accepted by Wytter on Dec 22 2005. Sorry for the delay.