Network

[Trurl]

Cleaned up the network code in client, now there's one function for sending each type of packet...

I don't know if you like it, because it involves a lot of code change only for sake of structure.

All network packet sending functions can be found in network.c...

 

network_cleanup.patch

[waldi]

nice work :-)

 

how about adding support for big-endian byteorder and archs that need alignment ?

[Trurl]

Isn't that already done in the SDL_net functions?

[waldi]

SDL_net doesn't know what type of data you are sending...

 

void send_TRADE_WITH(int actId) {

Uint8 msg[6];

msg[0]=TRADE_WITH;

*((int *)(msg+1))=actId; <- how should it know that there's an int in the Uint8 array

my_tcp_send(my_socket,msg,5);

}

 

exactly that line would generate an bus-error on sparc cpu's cuz the pointer isn't int aligned...

[Trurl]

Sorry, that's just the way I found it in interface.c...

[waldi]

np...but its a good idea to put it all in one file like u did...so there's only one place to look at if some1 wants to do the byteoder/alignment stuff...or some future protocol changes

[Trurl]

yep, exactly my thought... I would fix this (*int) thingy if I knew what to replace it with...

[waldi]

void send_TRADE_WITH(int actId) {

Uint8 msg[6];

msg[0]=TRADE_WITH;

memcpy(msg+1, &actId, sizeof (actId));

my_tcp_send(my_socket,msg,5);

}

 

or:

 

void send_TRADE_WITH(int actId) {

Uint8 msg[8];

msg[3]=TRADE_WITH;

*((int *)(msg+4))=actId; <- how should it know that there's an int in the Uint8 array

my_tcp_send(my_socket,msg+3,5);

}

[Trurl]

Changed it and updated the patch.

[waldi]

u should wait for some1 to accept ur patch first...

[Cicero]

His point was that every place that had that kind of int casting would cause an error on archs that require alignment, not just in that one function

[Learner]

In my Ant bot code I handle the sending of packets differently to make things easier. I use writePacket(packetType, dataLength, *dataPtr). And dataLength is the length of the data pointed to by dataPtr and writePacket handles the +1 so I never forget. Then writePacket is responsible for assembling the data to be sent to the server in the proper order.

 

I've found that method to be handy in keeping my code nice and simple.

[Wytter]

In my Ant bot code I handle the sending of packets differently to make things easier. I use writePacket(packetType, dataLength, *dataPtr). And dataLength is the length of the data pointed to by dataPtr and writePacket handles the +1 so I never forget. Then writePacket is responsible for assembling the data to be sent to the server in the proper order.

 

I've found that method to be handy in keeping my code nice and simple.

I use a similiar function in Gambler.

I think that using seperate functions for all packages send by the client is somewhat overkill. When that is said the current my_tcp_send is somewhat annoying and could be implemented in a smarter way (like the Ant's and Gambler handles these).

[Trurl]

As you like it, just meant as a suggestion

In my opinion it is not a very structured way to encode each packet separately each time you want to send it. It is hard to read the code and it is hard to change or fix it in case something is wrong if you have several places to look at.

[duran]

heh, didnt you talk about creaping featureitis the other day cicero? maybe this patch can help a bit?

[Wytter]

As you like it, just meant as a suggestion

In my opinion it is not a very structured way to encode each packet separately each time you want to send it. It is hard to read the code and it is hard to change or fix it in case something is wrong if you have several places to look at.

It's not a bad idea either - I'd just prefer having it all in my_tcp_send(TCPsocket socket, void *dataPtr, int type, int length) and then do a switch(type) :-) Having that many different functions that practically does the same just seems like a waste.

[frak]

btw. SDL_net does the byteordering if u use the SDL_Net_Write/Read functions (network byteorder)

[Learner]

btw. SDL_net does the byteordering if u use the SDL_Net_Write/Read functions (network byteorder)

Yes it would, except the byte order EL uses iw backwards to the standard network byte order.