1 Sec Music

[Leeloo]

Ok, I spent some time trying to debug my problem with music playing for 1 second then turning off, without getting any further than that it had to be an uninitialized variable somewhere (hey, how else can it happen to only a few people?)

 

I gave up debugging, and thought "why not let the compiler do the job". So, I added "-O -Werror" to the debug build command line, and:

 

cc -march=i686 -O -Wall -Werror -ggdb -pipe -DLINUX -DELC -I/usr/local/include/SDL -D_REENTRANT -I/usr/local/include/libxml2 -c sound.c
cc1: warnings being treated as errors
sound.c: In function `update_music':
sound.c:321: warning: `fade' might be used uninitialized in this function
make: *** [sound.o] Error 1

 

Perfect, initializing fade to zero makes the music play as it should. Please apply ASAP - and consider making -O -Werror part of the debug build process.

[Leeloo]

No comments on this, and not fixed in CVS yet... Did all the programmers leave for christmas holidays?

[Wytter]

cvs up

 

Added -Werror to the Makefile, i think you're quite right on that.

[crusadingknight]

No comments on this, and not fixed in CVS yet... Did all the programmers leave for christmas holidays?

I've been noticing that too. .

[Leeloo]

cvs up

 

Added -Werror to the Makefile, i think you're quite right on that.

-O is the one who finds variables that are used without being initialized.

[Wytter]

cvs up

 

Added -Werror to the Makefile, i think you're quite right on that.

-O is the one who finds variables that are used without being initialized.

Yea, and it's in CVS

[Cicero]

No comments on this, and not fixed in CVS yet... Did all the programmers leave for christmas holidays?

Not exactly, I was just away for a few days moving back home for the holidays, getting my computer re-connected at my parents' house, etc.