Jump to content
Eternal Lands Official Forums
Sign in to follow this  
Strings

notepad.c

Recommended Posts

Currently notepad.c is using xmlParseFile() to read in the XML file.

 

doc = xmlParseFile (file);

 

shouldn't that in fact be using

 

doc = xmlReadFile (file, "UTF-8", 0);

Share this post


Link to post
Share on other sites

Currently notepad.c is using xmlParseFile() to read in the XML file.

 

doc = xmlParseFile (file);

 

shouldn't that in fact be using

 

doc = xmlReadFile (file, "UTF-8", 0);

Yeah, it'd help to be able to take localised notes... still, there needs to be a whole new text editor widget written before the notepad is even usable. (My bad. ;) )

Share this post


Link to post
Share on other sites

Doesn't have to be a widget - how many times will we need to use a text editor widget? Just needs to work...

Edited by Wytter

Share this post


Link to post
Share on other sites

Doesn't have to be a widget - how many times will we need to use a text editor widget? Just needs to work...

Not necessarily a reusable widget as such... but using the current text_field, which is only intended for small sections of text will not work, nor will optimizing text_field (as text_field is currently not so much text, as chat window, and one-line text processing.) Just an actual text widget, without the channel stuff, etc, could be used in the Config. Window, Notepad window, and other misc. places, since our current "text field" is actually optimized for chat.

Share this post


Link to post
Share on other sites

xmlParseFile() assumes UTf-8 if no encoding is specified in the XML file, sorry but I can't see any benefit in xmlReadFile(), it's fine to use either.

Share this post


Link to post
Share on other sites

xmlParseFile() assumes UTf-8 if no encoding is specified in the XML file, sorry but I can't see any benefit in xmlReadFile(), it's fine to use either.

 

If I could suggest you look at the documentation for the two functions

 

xmlParseCatalogFile

xmlSAXParseFileWithData

 

I hope that the difference between the two functions becomes more clear, and you understand my suggestion.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Recently Browsing   0 members

    No registered users viewing this page.

×