Florian Report post Posted August 7, 2007 And another one #0 fail (msg1=0x46f7e28 "*** stack smashing detected ***: ", msg1len=33, msg3=0x46f7e04 "stack smashing detected: terminated") at ../../../gcc-4.2.1/libssp/ssp.c:145 #1 0x0007e96f in pre_check_if_ignored (input_text=0xbfffcbc8 "Spartan_Warrior: what?", len=24, channel=<value optimized out>) at ignore.c:299 #2 0x000e6cce in filter_or_ignore_text (text_to_add=0xbfffcbc8 "Spartan_Warrior: what?", len=24, size=8192, channel=0 '\0') at text.c:393 #3 0x000a5e20 in process_message_from_server (in_data=0x196b9cb0 "", data_length=28) at multiplayer.c:481 #4 0x0009bf73 in start_rendering () at main.c:154 Share this post Link to post Share on other sites
Torg Report post Posted August 8, 2007 Crash in WSC arena durink ~LE~ PK event <snip> #1 0x0007d37b in pre_check_if_ignored (input_text=0xbfffcbc8 "Shadow_of_death: heya Eifi", len=28, channel=<value optimized out>) at ignore.c:299 <snip> /EDIT: and again ... <snip> #1 0x0007d37b in pre_check_if_ignored (input_text=0xbfffcb48 "Shadow_of_death: hey SoF", len=26, channel=<value optimized out>) at ignore.c:299 <snip> And another one <snip> #1 0x0007e96f in pre_check_if_ignored (input_text=0xbfffcbc8 "Spartan_Warrior: what?", len=24, channel=<value optimized out>) at ignore.c:299 <snip> These are both caused because the players name is longer than MAX_USERNAME_LENGTH (14 chars). They are both 15. What I'd like to know is how come they are 15 when the client limits the name in creation to 14 chars. I'm guessing they are a result of name changes, without checking the length of the name. I've extended the client to support 16 chars in a name, but I'm not sure this is the best option. It will fix the CVS client for the time being and I'll try to chase Learner or Ent up about it. Share this post Link to post Share on other sites
kibora Report post Posted August 8, 2007 Could someone add to global.h #ifdef _MSC_VER #define __inline__ __inline #endif And uint32_t is still undefined in zipfilesystem.cpp Share this post Link to post Share on other sites
Torg Report post Posted August 8, 2007 #ifdef _MSC_VER#define __inline__ __inline #endif Ok, now we have CVS access back, I've added it, but I added it to platform.h because being a plaform specific fix, that is where it should be. And uint32_t is still undefined in zipfilesystem.cpp Looking at the mess in the only other location this is defined (amx.h)... I'll leave it to Grum. ;-) Share this post Link to post Share on other sites
Aislinn Report post Posted August 8, 2007 These are both caused because the players name is longer than MAX_USERNAME_LENGTH (14 chars). They are both 15. What I'd like to know is how come they are 15 when the client limits the name in creation to 14 chars. I'm guessing they are a result of name changes, without checking the length of the name. Since when? I just recently (July 31) had to lock a character creation name named assssssssssssss (1 a and 14 s's). We get a fair number of spam names like that so it's habit to just count to 15 to type it in to lock, so I know it's been 15 unless it is a very recent change.#Server: Our newest member is assssssssssssss ! Share this post Link to post Share on other sites
Learner Report post Posted August 8, 2007 Crash in WSC arena durink ~LE~ PK event <snip> #1 0x0007d37b in pre_check_if_ignored (input_text=0xbfffcbc8 "Shadow_of_death: heya Eifi", len=28, channel=<value optimized out>) at ignore.c:299 <snip> /EDIT: and again ... <snip> #1 0x0007d37b in pre_check_if_ignored (input_text=0xbfffcb48 "Shadow_of_death: hey SoF", len=26, channel=<value optimized out>) at ignore.c:299 <snip> And another one <snip> #1 0x0007e96f in pre_check_if_ignored (input_text=0xbfffcbc8 "Spartan_Warrior: what?", len=24, channel=<value optimized out>) at ignore.c:299 <snip> These are both caused because the players name is longer than MAX_USERNAME_LENGTH (14 chars). They are both 15. What I'd like to know is how come they are 15 when the client limits the name in creation to 14 chars. I'm guessing they are a result of name changes, without checking the length of the name. I've extended the client to support 16 chars in a name, but I'm not sure this is the best option. It will fix the CVS client for the time being and I'll try to chase Learner or Ent up about it. Thats character positions 0 thru 15 for a total count of 16 characters. Share this post Link to post Share on other sites
ttlanhil Report post Posted August 8, 2007 (edited) Thats character positions 0 thru 15 for a total count of 16 characters.When I made that define, I went through the code, and 14 seemed to be the most common number (well, <15 was more common than <=14, but still). There were also some 15s and I think one or two 16s (often for a trailing null, but that doesn't account for all extra spaces)... It was a mess (hence changing it to just one declaration of the size).If the server expects up to 16, not including trailing NULL, then Torg's recent fix makes the client correct. If the server expects less (eg 16 including the null), then the client could send over-long login/newchar messages, but otherwise should not have any problems. Edited August 8, 2007 by ttlanhil Share this post Link to post Share on other sites
kibora Report post Posted August 9, 2007 Ok, now we have CVS access back, I've added it, but I added it to platform.h because being a plaform specific fix, that is where it should be. In such case could you add #include "platform.h" to cache.h Share this post Link to post Share on other sites
Ermabwed Report post Posted August 10, 2007 The difference between mousewheel zoom and page up/down zoom was reintroduced, as in mousewheel zooms out further. I don't know since when that's the case again. Share this post Link to post Share on other sites
Ermabwed Report post Posted August 11, 2007 I get the following segfault, I can reproduce it: enter a target for map walk, switch to normal game screen, move EL window slightly off desktop (I used just a few pixels to the left; just checked, doesn't seem to crash when I move window off to the right). Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 47170641562480 (LWP 5584)] 0x00002ae6c5f2e998 in ?? () from /usr/lib64/dri/fglrx_dri.so (gdb) backtrace #0 0x00002ae6c5f2e998 in ?? () from /usr/lib64/dri/fglrx_dri.so #1 0x00002ae6c5f3323d in __glReadSpan () from /usr/lib64/dri/fglrx_dri.so #2 0x00002ae6c5d79cbd in __glSpanReadRGBA2 () from /usr/lib64/dri/fglrx_dri.so #3 0x00002ae6c5d7329c in __glGenericPickReadPixels () from /usr/lib64/dri/fglrx_dri.so #4 0x00002ae6c5d73048 in __glSlowPickReadPixels () from /usr/lib64/dri/fglrx_dri.so #5 0x00002ae6c5d62695 in __glim_ReadPixels () from /usr/lib64/dri/fglrx_dri.so #6 0x00002ae6c5d62593 in __glim_ReadPixels () from /usr/lib64/dri/fglrx_dri.so #7 0x00002ae6c5d62593 in __glim_ReadPixels () from /usr/lib64/dri/fglrx_dri.so #8 0x0000000000476413 in anything_under_the_mouse ( object_id=0, object_type=4) at misc.c:142 #9 0x0000000000452eaa in display_game_handler ( win=0x45bf4e0) at gamewin.c:995 #10 0x0000000000444a6c in draw_window (win=0x45bf4e0) at elwindows.c:1076 #11 0x0000000000445137 in display_window (win_id=0) at elwindows.c:1243 #12 0x0000000000442312 in display_windows (level=1) at elwindows.c:65 #13 0x000000000043af43 in draw_scene () at draw_scene.c:129 #14 0x000000000047198c in start_rendering () at main.c:167 #15 0x0000000000471d39 in main (argc=1, argv=0x7fffe7a6c948) at main.c:287 Share this post Link to post Share on other sites
Torg Report post Posted August 11, 2007 (edited) I get the following segfault, I can reproduce it: enter a target for map walk, switch to normal game screen, move EL window slightly off desktop (I used just a few pixels to the left; just checked, doesn't seem to crash when I move window off to the right). <snip> #8 0x0000000000476413 in anything_under_the_mouse ( object_id=0, object_type=4) at misc.c:142 <snip> Looking at that, I'm guessing your mouse cursor is off the screen when you do this. If you try it to the right, and make sure the mouse is also off the screen I expect it will also seg fault. I guess we need to do some bounds checking for the mouse... ?? I'll stick to NEW_SOUND for the moment. /edit: Making it prettier. :-P Edited August 11, 2007 by Torg Share this post Link to post Share on other sites
Ermabwed Report post Posted August 11, 2007 Looking at that, I'm guessing your mouse cursor is off the screen when you do this. If you try it to the right, and make sure the mouse is also off the screen I expect it will also seg fault. No, mouse cursor is holding the window title bar (or whatever it's called) for moving the window around. The segfault occurs without moving as well (checked while harvesting). Mouse cursor was far away from left border upon segfault. I can move the EL window off screen to the right as far as I want (or as far as the window manager allows it) without segfaulting. Share this post Link to post Share on other sites
crusadingknight Report post Posted August 11, 2007 Could you possibly reproduce this, and then step up into the anything_under_the_mouse function (using the 'up' command until you reach it), and then post the output of running each of 'p mouse_x', 'p mouse_y', and 'p window_height'? I think that would quite accurately determine if it was the client, or the GL implementation which is at fault. Share this post Link to post Share on other sites
Ermabwed Report post Posted August 11, 2007 #8 0x0000000000476413 in anything_under_the_mouse ( object_id=0, object_type=4) at misc.c:142 142 glReadPixels(mouse_x, window_height-mouse_y, 1, 1, GL_RGB, GL_BYTE, &pixels); (gdb) p mouse_x $1 = 818 (gdb) p mouse_y $2 = 15 (gdb) p window_height $3 = 720 Share this post Link to post Share on other sites
Grum Report post Posted August 12, 2007 I haven't looked at the actual function yet (will do so tomorrow, if still necessary), but I suspect the second to argument to glReadPixels should be window_height-hud_y-mouse_y. And Grum's back from vacation, seems you guys had a lot of fun cleaning up the removal of global.h Share this post Link to post Share on other sites
Beaverhunter Report post Posted August 13, 2007 So... It's been some days now and nothing happening to these errors: 1>Compiling... 1>parser.c 1>c:\dev\elc\books\parser.h(41) : error C2146: syntax error : missing ')' before identifier 'doc' 1>c:\dev\elc\books\parser.h(41) : error C2081: 'xmlDocPtr' : name in formal parameter list illegal 1>c:\dev\elc\books\parser.h(41) : error C2061: syntax error : identifier 'doc' 1>c:\dev\elc\books\parser.h(41) : error C2059: syntax error : ';' 1>c:\dev\elc\books\parser.h(41) : error C2059: syntax error : ')' 1>.\books\parser.c(63) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(63) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(63) : error C2059: syntax error : ';' 1>.\books\parser.c(63) : error C2059: syntax error : ')' 1>.\books\parser.c(77) : error C2146: syntax error : missing ')' before identifier 'doc' 1>.\books\parser.c(77) : error C2081: 'xmlDocPtr' : name in formal parameter list illegal 1>.\books\parser.c(77) : error C2061: syntax error : identifier 'doc' 1>.\books\parser.c(77) : error C2059: syntax error : ';' 1>.\books\parser.c(77) : error C2059: syntax error : ')' 1>.\books\parser.c(78) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(78) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(78) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(78) : error C2059: syntax error : ';' 1>.\books\parser.c(78) : error C2059: syntax error : ')' 1>.\books\parser.c(79) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(79) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(79) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(79) : error C2059: syntax error : ';' 1>.\books\parser.c(79) : error C2059: syntax error : ')' 1>.\books\parser.c(80) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(80) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(80) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(80) : error C2059: syntax error : ';' 1>.\books\parser.c(80) : error C2059: syntax error : ')' 1>.\books\parser.c(81) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(81) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(81) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(81) : error C2059: syntax error : ';' 1>.\books\parser.c(81) : error C2059: syntax error : ')' 1>.\books\parser.c(82) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(82) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(82) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(82) : error C2059: syntax error : ';' 1>.\books\parser.c(82) : error C2059: syntax error : ')' 1>.\books\parser.c(83) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(83) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(83) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(83) : error C2059: syntax error : ';' 1>.\books\parser.c(83) : error C2059: syntax error : ')' 1>.\books\parser.c(84) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(84) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(84) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(84) : error C2059: syntax error : ';' 1>.\books\parser.c(84) : error C2059: syntax error : ',' 1>.\books\parser.c(84) : error C2059: syntax error : ')' 1>.\books\parser.c(85) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(85) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(85) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(85) : error C2059: syntax error : ';' 1>.\books\parser.c(85) : error C2059: syntax error : ')' 1>.\books\parser.c(86) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(86) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(86) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(86) : error C2059: syntax error : ';' 1>.\books\parser.c(86) : error C2059: syntax error : ')' 1>.\books\parser.c(87) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(87) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(87) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(87) : error C2059: syntax error : ';' 1>.\books\parser.c(87) : error C2059: syntax error : ')' 1>.\books\parser.c(88) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(88) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(88) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(88) : error C2059: syntax error : ';' 1>.\books\parser.c(88) : error C2059: syntax error : ',' 1>.\books\parser.c(88) : error C2059: syntax error : ')' 1>.\books\parser.c(89) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(89) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(89) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(89) : error C2059: syntax error : ';' 1>.\books\parser.c(89) : error C2059: syntax error : ')' 1>.\books\parser.c(90) : error C2146: syntax error : missing ')' before identifier 'node' 1>.\books\parser.c(90) : error C2081: 'xmlNodePtr' : name in formal parameter list illegal 1>.\books\parser.c(90) : error C2061: syntax error : identifier 'node' 1>.\books\parser.c(90) : error C2059: syntax error : ';' 1>.\books\parser.c(90) : error C2059: syntax error : ')' 1>.\books\parser.c(92) : error C2146: syntax error : missing ')' before identifier 'attr' 1>.\books\parser.c(92) : error C2081: 'xmlAttrPtr' : name in formal parameter list illegal 1>.\books\parser.c(92) : error C2061: syntax error : identifier 'attr' 1>.\books\parser.c(92) : error C2059: syntax error : ';' 1>.\books\parser.c(92) : error C2059: syntax error : ')' 1>.\books\parser.c(93) : error C2146: syntax error : missing ')' before identifier 'attr' 1>.\books\parser.c(93) : error C2081: 'xmlAttrPtr' : name in formal parameter list illegal 1>.\books\parser.c(93) : error C2061: syntax error : identifier 'attr' 1>.\books\parser.c(93) : error C2059: syntax error : ';' 1>.\books\parser.c(93) : error C2059: syntax error : ')' 1>.\books\parser.c(94) : error C2146: syntax error : missing ')' before identifier 'attr' 1>.\books\parser.c(94) : error C2081: 'xmlAttrPtr' : name in formal parameter list illegal 1>.\books\parser.c(94) : error C2061: syntax error : identifier 'attr' 1>.\books\parser.c(94) : error C2059: syntax error : ';' 1>.\books\parser.c(94) : error C2059: syntax error : ')' 1>.\books\parser.c(95) : error C2146: syntax error : missing ')' before identifier 'attr' 1>.\books\parser.c(95) : error C2081: 'xmlAttrPtr' : name in formal parameter list illegal 1>.\books\parser.c(95) : error C2061: syntax error : identifier 'attr' 1>.\books\parser.c(95) : error C2059: syntax error : ';' 1>.\books\parser.c(95) : error C2059: syntax error : ')' 1>.\books\parser.c(95) : fatal error C1003: error count exceeds 100; stopping compilation 1>main.c 1>.\main.c(357) : error C2065: 'win_command_line' : undeclared identifier 1>fontdef.c 1>.\books\fontdef.c(25) : error C2065: 'datadir' : undeclared identifier Are people having their vacations now or what's up? Share this post Link to post Share on other sites
crusadingknight Report post Posted August 13, 2007 (edited) Actually, most of that is one error - surprised MSVC doesn't stop after a lower default limit than 100. Anyway, it looks like books/parser.h just needs to include <libxml/parser.h> and <libxml/tree.h>, main.c needs global.h to be included. The last one, I'm not so certain how to fix - it could either use the datadir check functions instead, or include init.h. EDIT: Make that platform.h in main.c, not typing what I'm thinking. Edited August 13, 2007 by crusadingknight Share this post Link to post Share on other sites
ttlanhil Report post Posted August 13, 2007 (edited) Actually, the books/* errors have another error... User error. They should not be compiled in unless you have ENCYCLOPEDIA set, which isn't even an option in make.defaults . Granted, they should have an #ifdef guard set as well, but they shouldn't be included at all. I'll go fix all except the user error ed: Done, hopefully all better now. Edited August 13, 2007 by ttlanhil Share this post Link to post Share on other sites
bluap Report post Posted August 23, 2007 (edited) Current CVS does not appear to compile unless you use NEW_SOUND. gcc -march=i686 -Wall -Wdeclaration-after-statement -O0 -ggdb -pipe -DLINUX -DELC -DAFK_FIX -DALPHA_ACTORS -DATI_9200_FIX -DAUTO_UPDATE -DCLICKABLE_CONTINENT_MAP -DCLUSTER_INSIDES -DCOUNTERS -DCUSTOM_LOOK -DCUSTOM_UPDATE -DEYE_CANDY -DFONTS_FIX -DFUZZY_PATHS -DIDLE_FIX -DMASKING -DMINIMAP -DNEW_ACTOR_ANIMATION -DNEW_TEX -DNEW_WEATHER -DNOTEPAD -DOGG_VORBIS -DOPTIONS_I18N -DPNG_SCREENSHOT -DSFX -DSIMPLE_LOD -DUSE_INLINE -DZLIB -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/libxml2 -fno-strict-aliasing -c -o actor_scripts.o actor_scripts.c actor_scripts.c: In function ‘parse_actor_script’: actor_scripts.c:2601: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2603: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2605: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2607: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2609: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2611: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2613: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2615: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2617: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2619: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2621: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2623: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2625: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2627: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2629: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2631: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2633: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2635: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2637: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2639: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2641: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2643: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2645: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2647: error: ‘struct cal_anim’ has no member named ‘sound’ actor_scripts.c:2649: error: ‘struct cal_anim’ has no member named ‘sound’ make: *** [actor_scripts.o] Error 1 Edited August 23, 2007 by bluap Share this post Link to post Share on other sites
Florian Report post Posted August 23, 2007 Current CVS does not appear to compile unless you use NEW_SOUND. Patch: Index: actor_scripts.c =================================================================== RCS file: /cvsroot/elc/elc/actor_scripts.c,v retrieving revision 1.190 diff -u -d -p -r1.190 actor_scripts.c --- actor_scripts.c 23 Aug 2007 15:17:16 -0000 1.190 +++ actor_scripts.c 23 Aug 2007 20:02:06 -0000 @@ -2598,55 +2598,58 @@ int parse_actor_script (xmlNode *cfg) } act->cal_walk_frame.anim_index= -1; - act->cal_walk_frame.sound= -1; act->cal_run_frame.anim_index= -1; - act->cal_run_frame.sound= -1; act->cal_die1_frame.anim_index= -1; - act->cal_die1_frame.sound= -1; act->cal_die2_frame.anim_index= -1; - act->cal_die2_frame.sound= -1; act->cal_pain1_frame.anim_index= -1; - act->cal_pain1_frame.sound= -1; act->cal_pain2_frame.anim_index= -1; - act->cal_pain2_frame.sound= -1; act->cal_pick_frame.anim_index= -1; - act->cal_pick_frame.sound= -1; act->cal_drop_frame.anim_index= -1; - act->cal_drop_frame.sound= -1; act->cal_idle1_frame.anim_index= -1; - act->cal_idle1_frame.sound= -1; act->cal_idle2_frame.anim_index= -1; - act->cal_idle2_frame.sound= -1; act->cal_idle_sit_frame.anim_index= -1; - act->cal_idle_sit_frame.sound= -1; act->cal_harvest_frame.anim_index= -1; - act->cal_harvest_frame.sound= -1; act->cal_attack_cast_frame.anim_index= -1; - act->cal_attack_cast_frame.sound= -1; act->cal_attack_ranged_frame.anim_index= -1; - act->cal_attack_ranged_frame.sound= -1; act->cal_sit_down_frame.anim_index= -1; - act->cal_sit_down_frame.sound= -1; act->cal_stand_up_frame.anim_index= -1; - act->cal_stand_up_frame.sound= -1; act->cal_in_combat_frame.anim_index= -1; - act->cal_in_combat_frame.sound= -1; act->cal_out_combat_frame.anim_index= -1; - act->cal_out_combat_frame.sound= -1; act->cal_combat_idle_frame.anim_index= -1; - act->cal_combat_idle_frame.sound= -1; act->cal_attack_up_1_frame.anim_index= -1; - act->cal_attack_up_1_frame.sound= -1; act->cal_attack_up_2_frame.anim_index= -1; - act->cal_attack_up_2_frame.sound= -1; act->cal_attack_up_3_frame.anim_index= -1; - act->cal_attack_up_3_frame.sound= -1; act->cal_attack_up_4_frame.anim_index= -1; - act->cal_attack_up_4_frame.sound= -1; act->cal_attack_down_1_frame.anim_index= -1; - act->cal_attack_down_1_frame.sound= -1; act->cal_attack_down_2_frame.anim_index= -1; + +#ifdef NEW_SOUND + act->cal_walk_frame.sound= -1; + act->cal_run_frame.sound= -1; + act->cal_die1_frame.sound= -1; + act->cal_die2_frame.sound= -1; + act->cal_pain1_frame.sound= -1; + act->cal_pain2_frame.sound= -1; + act->cal_pick_frame.sound= -1; + act->cal_drop_frame.sound= -1; + act->cal_idle1_frame.sound= -1; + act->cal_idle2_frame.sound= -1; + act->cal_idle_sit_frame.sound= -1; + act->cal_harvest_frame.sound= -1; + act->cal_attack_cast_frame.sound= -1; + act->cal_attack_ranged_frame.sound= -1; + act->cal_sit_down_frame.sound= -1; + act->cal_stand_up_frame.sound= -1; + act->cal_in_combat_frame.sound= -1; + act->cal_out_combat_frame.sound= -1; + act->cal_combat_idle_frame.sound= -1; + act->cal_attack_up_1_frame.sound= -1; + act->cal_attack_up_2_frame.sound= -1; + act->cal_attack_up_3_frame.sound= -1; + act->cal_attack_up_4_frame.sound= -1; + act->cal_attack_down_1_frame.sound= -1; act->cal_attack_down_2_frame.sound= -1; +#endif // NEW_SOUND for (i=0; i<80; ++i){ act->weapon[i].cal_attack_up_1_frame.anim_index=-1; Share this post Link to post Share on other sites
Torg Report post Posted August 24, 2007 Current CVS does not appear to compile unless you use NEW_SOUND. Yeah, sorry about that. Florian's code will fix it (as you know). It will be in when Berlios is back up. Share this post Link to post Share on other sites
bluap Report post Posted August 24, 2007 (edited) Current CVS does not appear to compile unless you use NEW_SOUND. Yeah, sorry about that. Florian's code will fix it (as you know). It will be in when Berlios is back up. OK, thanks. It was a good excuse to download the new sound files and the new models and have a listen to all your hard work. Great stuff, lots of sound, a whole new dimension to the game. The first few times I heard that bag pick-up/destroy sound, I wondered what on earth was going on. Thought some great monster was going to eat me. Nice work anyway. One issue I'm still having with sound though. Even though my CPU is not running at anything like 100% (I have FPS capped quite low). The sounds and music regularly start to sound as if they are playing back slower than intended (a downwards pitch shift and more metallic kind of sound). This also happens with the old sound code but never use to happen before the 1.4 release. I've not changed my hardware at all so its curious. Edit: Sorry, just remembered which thread I'm in, I repost the last paragraph to the sound thread..... Edited August 24, 2007 by bluap Share this post Link to post Share on other sites
Torg Report post Posted August 24, 2007 OK, thanks. It was a good excuse to download the new sound files and the new models and have a listen to all your hard work. Great stuff, lots of sound, a whole new dimension to the game. The first few times I heard that bag pick-up/destroy sound, I wondered what on earth was going on. Thought some great monster was going to eat me. Nice work anyway. Hehehe, yeah... that was a mistaken config setting. I had actually though I'd pulled it out of the most recent package... oh well. Glad you enjoy. :-) Out of interest... I've finally got access to Berlios again so the fix should be in. Share this post Link to post Share on other sites
Florian Report post Posted August 24, 2007 Current CVS warnings (-Wall): cal.c: In function 'cal_load_anim': cal.c:161: warning: dereferencing type-punned pointer will break strict-aliasing rules elconfig.c: In function 'change_shadow_map_size': elconfig.c:633: warning: passing argument 2 of 'glGetIntegerv' from incompatible pointer type font.c: In function 'reload_fonts': font.c:1248: warning: dereferencing type-punned pointer will break strict-aliasing rules gl_init.c: In function 'set_new_video_mode': gl_init.c:1011: warning: dereferencing type-punned pointer will break strict-aliasing rules lights.c: In function 'test_point_visible': lights.c:119: warning: passing argument 2 of 'glGetIntegerv' from incompatible pointer type lights.c:121: warning: passing argument 6 of 'gluProject' from incompatible pointer type misc.c: In function 'makeScreenShot': misc.c:435: warning: passing argument 2 of 'glGetIntegerv' from incompatible pointer type particles.c: In function 'load_particle_def': particles.c:145: warning: format '%x' expects type 'unsigned int *', but argument 3 has type 'GLenum *' particles.c:145: warning: format '%x' expects type 'unsigned int *', but argument 4 has type 'GLenum *' sound.c: In function 'ensure_sample_loaded': sound.c:2529: warning: 'alutLoadWAVFile' is deprecated (declared at /Library/Frameworks/OpenAL.framework/Headers/alut.h:110) sound.c:2588: warning: 'alutUnloadWAV' is deprecated (declared at /Library/Frameworks/OpenAL.framework/Headers/alut.h:116) sound.c:2490: warning: unused variable 'loop' sound.c: In function 'stream_ogg_file': sound.c:1739: warning: 'more_stream' may be used uninitialized in this function sound.c: In function 'update_streams': sound.c:2220: warning: 'old_ty' may be used uninitialized in this function sound.c:2220: warning: 'old_tx' may be used uninitialized in this function url.c: In function 'open_web_link': url.c:350: warning: implicit declaration of function 'LSOpenCFURLRef' shader/shader.c: In function 'load_shader': shader/shader.c:59: warning: passing argument 4 of 'ELglShaderSourceARB' from incompatible pointer type shader/shader.c: In function 'build_shader': shader/shader.c:220: warning: passing argument 2 of 'ELglDeleteProgramsARB' from incompatible pointer type shader/shader.c:238: warning: passing argument 2 of 'ELglDeleteProgramsARB' from incompatible pointer type shader/shader.c: In function 'free_shaders': shader/shader.c:266: warning: passing argument 2 of 'ELglDeleteProgramsARB' from incompatible pointer type pawn/amx.c: In function 'amx_PushString': pawn/amx.c:1793: warning: implicit declaration of function 'wcslen' pawn/amxcons.c: In function 'amx_printstring': pawn/amxcons.c:457: warning: 'filler' may be used uninitialized in this function pawn/amxcons.c:457: warning: 'decpoint' may be used uninitialized in this function pawn/amxcons.c:457: warning: 'sign' may be used uninitialized in this function pawn/amxcons.c:456: warning: 'digits' may be used uninitialized in this function pawn/amxcons.c:456: warning: 'width' may be used uninitialized in this function pawn/amxfloat.c: In function 'n_float': pawn/amxfloat.c:50: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_strfloat': pawn/amxfloat.c:83: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatmul': pawn/amxfloat.c:96: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatdiv': pawn/amxfloat.c:109: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatadd': pawn/amxfloat.c:122: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatsub': pawn/amxfloat.c:135: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatfract': pawn/amxfloat.c:149: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatsqroot': pawn/amxfloat.c:219: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatpower': pawn/amxfloat.c:234: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatlog': pawn/amxfloat.c:254: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatsin': pawn/amxfloat.c:282: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatcos': pawn/amxfloat.c:297: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floattan': pawn/amxfloat.c:312: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/amxfloat.c: In function 'n_floatabs': pawn/amxfloat.c:321: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/elpawn.c: In function 'run_pawn_function': pawn/elpawn.c:237: warning: dereferencing type-punned pointer will break strict-aliasing rules pawn/elpawn.c:236: warning: 'float' is promoted to 'double' when passed through '...' pawn/elpawn.c:236: warning: (so you should pass 'double' not 'float' to 'va_arg') pawn/elpawn.c:236: note: if this code is reached, the program will abort io/elpathwrapper.c:50:33: warning: unknown escape sequence: '\040' io/elpathwrapper.c:50:33: warning: unknown escape sequence: '\040' eye_candy/effect_wind.cpp: In constructor 'ec::WindParticle::WindParticle(ec::Effect*, ec::ParticleMover*, ec::Vec3, ec::Vec3, color_t, color_t, coord_t, coord_t, coord_t, ec::WindEffect::WindType)': eye_candy/effect_wind.cpp:27: warning: 'value' may be used uninitialized in this function eye_candy/effect_wind.cpp:27: warning: 'saturation' may be used uninitialized in this function eye_candy/effect_wind.cpp:27: warning: 'hue' may be used uninitialized in this function eye_candy/effect_wind.cpp: In constructor 'ec::WindParticle::WindParticle(ec::Effect*, ec::ParticleMover*, ec::Vec3, ec::Vec3, color_t, color_t, coord_t, coord_t, coord_t, ec::WindEffect::WindType)': eye_candy/effect_wind.cpp:27: warning: 'value' may be used uninitialized in this function eye_candy/effect_wind.cpp:27: warning: 'saturation' may be used uninitialized in this function eye_candy/effect_wind.cpp:27: warning: 'hue' may be used uninitialized in this function As always, I have no idea what that means but maybe one of you knows whether those warnings are bad or not. Share this post Link to post Share on other sites
Florian Report post Posted August 27, 2007 (edited) X86_64 still breaks pawn. from error_log: Unable to determine memory size for Pawn file pawn_scripts/pawn_test.amx Unable to execute Pawn function: machine not initialized Edited August 27, 2007 by Florian Share this post Link to post Share on other sites
