Proposed addition to makefile.win

[LabRat]

# basic compiling and linking - rarely changed
OPTIONS = -DWINDOWS -DELC $(foreach FEATURE, $(FEATURES), -D$(FEATURE))

 

I propose adding

-mwindows

to the above line:

# basic compiling and linking - rarely changed
OPTIONS = -DWINDOWS -DELC -mwindows $(foreach FEATURE, $(FEATURES), -D$(FEATURE))

 

-mwindows tells gcc to compile for Windows (specifically do not generate a console window)

 

Compilation is then just a case of

make -f makefile.win

on the windows command line (after the compiler bin folder is added to the system path)

 

Could the devs using windows IDEs please add the change manually and see if it breaks anything, if not I will ask to have the addition committed.

[ttlanhil]

note: this will not affect MSVC users*. they don't have to test.

*note: unless they use the command line version with nmake or similar. which I've heard no longer works with recent versions of MSVC

 

also, doing away with the console may not always be a good idea. some logging to console happens (even if the EYE_CANDY output makes it hard to see any other messages)

[freeone3000]

It doesn't remove console output, just the console that pops up. It would still be possible to run el.exe from the command line. The release client is compiled with this flag.