3d map markers

[bluap]

Just a note that when you are inside a building/cave etc, the 3d marks in other locations can be seen. This image is from a secret location in the north west of Whitestone. Don't ask why I have that storage marked, it was probably a test.....

[Fedora]

@bluap: mmm...the only thing I can do is to lower the clipping distance for markers. It is 30 tiles now iirc, probably half can do the job.

 

As suggested by bkc56 I added support for colored markers fully backward compatible with previous markers format:

- #mark_color r g b (range 0..255) sets the current marker color

All subsequent set markers are drawn with the picked color. Default color is green.

 

If it is approved I can commit it right away.

 

P.S.

There is a bug that allows to #unmark server sent markers...will commit the patch asap

Edited February 22, 2010 by Fedora

[bkc56]

- #mark_color r g b (range 0..255) sets the current marker color

All subsequent set markers are drawn with the picked color. Default color is green.

This seems great! I'd like to make a couple suggestions to the command:

 

1. "mark_color" (or perhaps "mark_color default") would return to the default color green.

 

2. "#mark_color <color name>" would support all the same colors that #set_guild_color does (red, blue, green, etc). That's a lot easier for a few basic colors than rgb values. This is what I was thinking when I suggested it.

 

3. It might also be helpful to be able to query the current marker color (especially for rgb values).

 

Finally, should it be #mark_color or #marker_color (or even without the "_")? What the most consistent with the current commands?

[Fedora]

Changes committed:

 

- clip distance for markers is 20 tiles

- #marker_color <r g b> (0..255) sets marker color to the RGB value

- #marker_color <color name> accepts (red,green,blue,yellow,cyan,magenta,white) as shortcuts

- #marker_color without arguments shows the current marker color

- #unmark on server sent markers now behaves correctly

 

The client should be able to read old marker files, but will overwrite them with the new format, so I recommend a backup just in case

[nathanstenzel]

About the map markers showing up from a different room than the one you are in.....

We often see rooms and such while in a submap which we shouldn't logically see.

 

Could we put up a series of tall black walls inbetween the different pieces of the submap so we don't see a piece we are not in? I don't think this should be too difficult to implement. It would just require a quick modification to the maps and it would correct both problems instead of just the map marker. I realize that this would require more effort than just changing 1 variable though.

 

If we halve the distance that a map marker is visible from, it won't be as useful on large maps where we should actually see them.

[Roja]

nathanstenzel, something like that would not be a quick fix at all to the maps, it won't be done.

 

 

Can someone implement an option in the config panel to disable viewing of the markers? This is so we can take screenshots and not have the text/marker show up.

[Fedora]

Can someone implement an option in the config panel to disable viewing of the markers? This is so we can take screenshots and not have the text/marker show up.

 

It's already there

 

Option -> HUD -> Enable 3d markers

[Roja]

Oh I'm blind...thank you!

[Roja]

One bug though, it seems I have to log out/log in for it to disable/enable.

[The_Piper]

One bug though, it seems I have to log out/log in for it to disable/enable.

 

Works fine for me, i dont need to relog to dis/enable the 3d markers.

 

Self compiled Linux client from February, 25th.

 

Piper

[Roja]

Sorry, I found it was the server mapmakers that it wasn't working for. We need them to disable too.

[Fedora]

cvs updated, now server markers can be hidden

 

EDIT

 

FYI cvs greeted me with the following message:

 

Checking in map.c;
/cvsroot/elc/elc/map.c,v  <--  map.c
new revision: 1.44; previous revision: 1.43
done
Mailing elc-cvs@lists.berlios.de...
Generating notification message...
Generating notification message... done.
Mailing elc-cvs@lists.berlios.de...
Generating notification message...
Traceback (most recent call last):
 File "/usr/local/bin/syncmail", line 322, in <module>
main()
 File "/usr/local/bin/syncmail", line 315, in main
blast_mail(subject, people, specs[1:], contextlines, fromhost)
 File "/usr/local/bin/syncmail", line 221, in blast_mail
conn.connect(MAILHOST, MAILPORT)
 File "/usr/lib/python2.6/smtplib.py", line 295, in connect
self.sock = self._get_socket(host, port, self.timeout)
 File "/usr/lib/python2.6/smtplib.py", line 273, in _get_socket
return socket.create_connection((port, host), timeout)
 File "/usr/lib/python2.6/socket.py", line 512, in create_connection
raise error, msg
socket.error: [Errno 111] Connection refused

 

map.c is correctly updated, it seems cvs can't send the update mails

Edited March 4, 2010 by Fedora

[The_Piper]

Obviously a problem with +-1

 

I have a map marker named "Fast regeneration spot", which is shown as a 3D marker as "Fast regeneration sp..".

 

So i suggest just to show the full name except replacing the last 2 chars with ".."

 

Piper